Skip to content

GH-137959: fix warning 'visibility' attribute ignored in jit/trampoline.c #140286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

GH-137959: fix warning 'visibility' attribute ignored in jit/trampoline.c #140286

wants to merge 1 commit into from

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Oct 18, 2025 •
edited by bedevere-app bot
Loading

Since #137961 we're getting this warning

/home/runner/work/cpython/cpython/Tools/jit/trampoline.c:13:13: warning: 'visibility' attribute ignored [-Wignored-attributes]
   13 |     typedef DECLARE_TARGET((*jit_func));
      |             ^
/home/runner/work/cpython/cpython/Tools/jit/jit.h:11:49: note: expanded from macro 'DECLARE_TARGET'
   11 |     _Py_CODEUNIT *__attribute__((preserve_none, visibility("hidden"))) \
      |                                                 ^
1 warning generated.

for all platforms, e.g.
https://github.com/python/cpython/actions/runs/18575809544/job/52961278295?pr=140233
except i686-pc-windows-msvc, where this warning has to be suppressed

cpython/Tools/jit/_targets.py

Lines 583 to 587 in f937468

elif re.fullmatch(r"i686-pc-windows-msvc", host):
host = "i686-pc-windows-msvc"
condition = "defined(_M_IX86)"
# -Wno-ignored-attributes: __attribute__((preserve_none)) is not supported here.
args = ["-DPy_NO_ENABLE_SHARED", "-Wno-ignored-attributes"]

to silence the many warnings we'd get otherwise, because preserve_none is not supported there.

I suggest to use

cpython/Tools/jit/jit.h

Lines 1 to 4 in f937468

// To use preserve_none in JIT builds, we need to declare a separate function
// pointer with __attribute__((preserve_none)), since this attribute may not be
// supported by the compiler used to build the rest of the interpreter.
typedef jit_func __attribute__((preserve_none)) jit_func_preserve_none;

I've verified with a small Godbolt demo and by comparing the emit_trampoline in the generated jit_stencils.h that the generated code remains the same.

@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2025
Closed
@Fidget-Spinner
Copy link
Member

I think Savannah already opened a PR for this here #139981. Perhaps you could review it?

@chris-eibl chris-eibl mentioned this pull request Oct 18, 2025
Open
@chris-eibl
Copy link
Member Author

Thanks Ken. Well spotted, I haven't seen Savannah's PR so closing mine.

@chris-eibl chris-eibl closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

Assignees

No one assigned

Labels

awaiting review skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-eibl @Fidget-Spinner